fix: resolve Verify Address crash caused by conditional hook call in ConnectChannel#6939
Open
Copilot wants to merge 3 commits into
Open
fix: resolve Verify Address crash caused by conditional hook call in ConnectChannel#6939Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Co-authored-by: Parsh <17980466+Parsh@users.noreply.github.com>
…address crash Co-authored-by: Parsh <17980466+Parsh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix app crash on verify address in receive screen
fix: resolve Verify Address crash caused by conditional hook call in ConnectChannel
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping "Verify Address" on the Receive screen instantly crashed the app due to a React Rules of Hooks violation in
ConnectChannel.tsx.Root Cause
useVaultwas called inside a conditional block, which corrupts React's hook call order and causes an immediate runtime crash:Fix
Hoisted
useVaultto the top level ofConnectChannel. The conditional block is retained solely for deriving address-verification values from the vault result:Affects all hardware signers routed through
ConnectChannelfor address verification (BitBox02, Ledger, Trezor, Coldcard, Jade). No logic or UX changes.